Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow returning invalid objects from writes #1304

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Allow returning invalid objects from writes #1304

merged 4 commits into from
Mar 8, 2023

Conversation

cmelchior
Copy link
Contributor

Closes #1300

@cla-bot cla-bot bot added the cla: yes label Mar 8, 2023
@cmelchior cmelchior requested a review from rorbech March 8, 2023 07:38
rorbech
rorbech reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@rorbech rorbech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess we could consider targeting release ... or is it safer to do in a minor release than in a patch release. And when CI is green of course.

@cmelchior cmelchior changed the base branch from main to releases March 8, 2023 12:12
@cmelchior cmelchior changed the base branch from releases to main March 8, 2023 12:12
@cmelchior cmelchior force-pushed the cm/return-invalid-objects-from-write branch from 71b6b93 to c4e895d Compare March 8, 2023 12:26
@cmelchior cmelchior changed the base branch from main to releases March 8, 2023 12:27
@cmelchior cmelchior merged commit bdb5bcc into releases Mar 8, 2023
@cmelchior cmelchior deleted the cm/return-invalid-objects-from-write branch March 8, 2023 19:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rorbech rorbech rorbech approved these changes

Assignees

@cmelchior cmelchior

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deleting Non-Optional Frozen RealmObject Crashes
2 participants
@cmelchior @rorbech