Add support for encrypting user metadata used by Sync. #1100
Conversation
...c/src/androidAndroidTest/kotlin/io/realm/kotlin/test/mongodb/shared/AppConfigurationTests.kt
Outdated
Show resolved
Hide resolved
...c/src/androidAndroidTest/kotlin/io/realm/kotlin/test/mongodb/shared/AppConfigurationTests.kt
Outdated
Show resolved
Hide resolved
.../library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/internal/AppConfigurationImpl.kt
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/AppConfiguration.kt
Show resolved
Hide resolved
...ages/test-sync/src/androidAndroidTest/kotlin/io/realm/kotlin/test/mongodb/shared/AppTests.kt
Outdated
Show resolved
Hide resolved
packages/library-sync/src/commonMain/kotlin/io/realm/kotlin/mongodb/AppConfiguration.kt
Show resolved
Hide resolved
...ages/test-sync/src/androidAndroidTest/kotlin/io/realm/kotlin/test/mongodb/shared/AppTests.kt
Outdated
Show resolved
Hide resolved
...ages/test-sync/src/androidAndroidTest/kotlin/io/realm/kotlin/test/mongodb/shared/AppTests.kt
Show resolved
Hide resolved
...ages/test-sync/src/androidAndroidTest/kotlin/io/realm/kotlin/test/mongodb/shared/AppTests.kt
Outdated
Show resolved
Hide resolved
...ages/test-sync/src/androidAndroidTest/kotlin/io/realm/kotlin/test/mongodb/shared/AppTests.kt
Outdated
Show resolved
Hide resolved
...ages/test-sync/src/androidAndroidTest/kotlin/io/realm/kotlin/test/mongodb/shared/AppTests.kt
Outdated
Show resolved
Hide resolved
| public class AppConfigurationImpl constructor( | ||
| override val appId: String, | ||
| override val baseUrl: String = DEFAULT_BASE_URL, | ||
| override val encryptionKey: ByteArray?, |
There was a problem hiding this comment.
Should we keep a copy of the encryption key at SDK level? I think that we should not keep any copy, as they should be safely stored by the user or core.
RealmConfiguration also stores a copy. For that case we have a core function to retrieve the key, that would help testing, but we lack of such function for the metadata encryption key.
We could address this in another PR.
There was a problem hiding this comment.
I agree, this is a bit of a smell, but I wouldn't consider it a big deal, since if you have access to read the memory where this key resides, you also have access to the open Realm and can just ask Core for the data.
There was a problem hiding this comment.
Interesting points. Currently, however, the exposed core function realm_config_get_encryption_key (not for metadata) is not used in any configuration class. The actual functions are implemented but yes, a copy is still being stored.
Description
Closes #413.
Users can encrypt user metadata via
AppConfiguration.Builder.encryptionKey()and access their encryption key viaAppConfiguration.encryptionKey.TODO