Fix SyncSession crashing when accessed after receiving remote changes #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edualonso
approved these changes
Oct 14, 2022
| @@ -768,6 +836,7 @@ class SyncedRealmTests { | |||
| localRealm.writeCopyTo(flexSyncConfig) | |||
| } | |||
| } | |||
| flexApp.close() | |||
| // 4. With the original native dbPointer now being closed, accessing the syncSession for | ||
| // the first time should still work. | ||
| try { | ||
| realm1.syncSession.pause() |
There was a problem hiding this comment.
If an error happens here it will get swallowed by the finally and we won't know whether the session is still accessible. I would check the session state has actually been updated after calling pause.
There was a problem hiding this comment.
Hmm, finally doesn't swallow the exception, it should still propagate and fail the test, but you are right. Checking the state would improve the test.
There was a problem hiding this comment.
Yes, I didn't mean an exception gets swallowed but rather that the state itself doesn't get updated for some reason. Poor wording 🙊
added 2 commits
October 14, 2022 11:19
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1068
Note, when creating this patch I discovered another bug: #1070.
A test has been written that catch this but it is marked as
@Ignorefor now.