Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Obj::has_schema_property #7898

Merged

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Jul 18, 2024

What, How & Why?

  • Add Obj::has_schema_property()
  • Expose Obj::has_schema_property(), TableRef::get_column_key(), and Obj::set_any_by_name() in bindgen

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

[bindgen] Expose Obj::has_schema_property(), TableRef::get_column_key(), and Obj::set_any_by_name()
@cla-bot cla-bot bot added the cla: yes label Jul 18, 2024
@kneth kneth added no-jira-ticket Skip checking the PR title for Jira reference and removed cla: yes labels Jul 18, 2024
@kneth kneth requested a review from jedelbo July 18, 2024 15:14
Copy link

Pull Request Test Coverage Report for Build kenneth.geisshirt_33

Details

  • 3596 of 4001 (89.88%) changed or added relevant lines in 63 files are covered.
  • 820 unchanged lines in 43 files lost coverage.
  • Overall coverage decreased (-0.01%) to 90.959%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/array_mixed.cpp 48 49 97.96%
src/realm/cluster_tree.cpp 40 42 95.24%
test/test_array.cpp 484 486 99.59%
src/realm/dictionary.cpp 18 21 85.71%
src/realm/object-store/c_api/config.cpp 0 3 0.0%
src/realm/query_conditions.hpp 64 67 95.52%
src/realm/bplustree.cpp 23 27 85.19%
src/realm/cluster.cpp 130 134 97.01%
src/realm/integer_flex_compressor.cpp 40 46 86.96%
src/realm/object-store/c_api/object.cpp 117 124 94.35%
Files with Coverage Reduction New Missed Lines %
src/realm/array.hpp 1 95.81%
src/realm/array_string.cpp 1 88.03%
src/realm/array_unsigned.cpp 1 85.35%
src/realm/dictionary.cpp 1 85.17%
src/realm/object-store/sync/sync_session.cpp 1 92.01%
src/realm/query_engine.hpp 1 93.94%
src/realm/table.hpp 1 92.41%
test/fuzz_tester.hpp 1 57.73%
src/realm/array_key.cpp 2 96.55%
src/realm/mixed.cpp 2 86.46%
Totals Coverage Status
Change from base Build 2497: -0.01%
Covered Lines: 218213
Relevant Lines: 239903

💛 - Coveralls

@kneth kneth changed the base branch from master to feature/flexible-schema July 19, 2024 08:59
@kneth kneth marked this pull request as ready for review August 7, 2024 10:40
@kneth kneth merged commit 1561070 into feature/flexible-schema Aug 7, 2024
41 of 45 checks passed
@kneth kneth deleted the kneth/flexible-schema/obj-has_schema_property branch August 7, 2024 10:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants