Delete long-obsolete tests and benchmarks #7695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit-tests-ios benchmark-common-tasks-ios: used by the pre-cmake build system.
benchmark-row-accessor: never updated for core 6 and the thing it was benchmarking isn't applicable any more.
benchmark-history-types: used to verify that moving the transaction logs into the Realm file wouldn't cause performance problems. The code being benchmarked no longer exists.
notifications-fuzzer: this was an important part of originally writing the diffing logic for notifications, but everything it exposed was turned into normal tests. It was never updated for core 6 and no bugs have ever been reported in the code this was testing.
test_client_reset_query_based.cpp: query-based sync is no longer a thing.
test_optional.cpp: this was actually testing std::optional. There's still some code in optional.hpp, but none of it was being tested here.
benchmark-transaction benchmark-prealloc benchmark-index benchmark-insert-add performance: these were pre-Realm benchmarks against the old macro-based TightDB API, which was deleted in 2016.
simple-connection: this was a manual testing tool from when sync first adopted websockets.
protocol_compact: this was a tool for testing one version of the server against a different version of the client, which we no longer care about.
There's a few other things in the test directory that don't currently build (benchmark-util-network and some of the fuzzers) but have been touched in the last few years and aren't testing something irrelevant so I left them.