RCORE-2115 Fix multiple backlinks created by dictionary #7677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f mixed creating multiple backlinks
danieltabacaru
approved these changes
May 3, 2024
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| ### Fixed | |||
| * <How do the end-user experience this issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?) | |||
| * Accessing App::current_user() from within a notification produced by App:switch_user() (which includes notifications for a newly logged in user) would deadlock ([#7670](https://github.com/realm/realm-core/issues/7670), since v14.6.0). | |||
| * Inserting the same typed link to the same key in a dictionary more than once would incorrectly create multiple backlinks to the object. This did not appear to cause any crashes later, but would have affecting explicit backlink count queries o@links.@count`) and possibly notifications ([#7676](https://github.com/realm/realm-core/issues/7676) since v14.5.2). | |||
There was a problem hiding this comment.
did you mean to have ` before o@links.@count?
Pull Request Test Coverage Report for Build james.stone_540Details
💛 - Coveralls |
jedelbo
pushed a commit
that referenced
this pull request
May 6, 2024
* fix inserting a link multiple times to the same key in a dictionary of mixed creating multiple backlinks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7676
This regression was caused by #7523
I couldn't cause any hard crashes or exceptions so it is hard to say that this has been observed outside of niche query cases.
This is because we have previously chosen to ignore nullifying backlinks that point to an object that no longer exists, since #6638
☑️ ToDos
bindgen/spec.yml, if public C++ API changed