Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit use of service role with change set workflow #70

Merged
merged 6 commits into from
Nov 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGES

## 1.6.0 (2020-11-19)

* Feature: Support --service-role-arn on "change-set create"

## 1.5.1 (2020-11-16)

* Fix: Recognise that template is in S3 when URL is formatted like `s3.REGION.amazonaws.com`
Expand Down
14 changes: 11 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,8 @@ You can also create, list, inspect, apply and delete [change sets](http://docs.a

The change-set name defaults to "pending", but can be overridden using `--name`.

The `change-set create` subcommand, like the `up` command, supports `--service-role-arn` to specify a service role.

## Programmatic usage

Get a handle to a `Stack` object as follows:
Expand Down Expand Up @@ -300,13 +302,19 @@ This policy grants the principal all actions required by `stackup up` for any cl
}
```

## Releasing
## Development

### Running tests

`auto/test` will run the tests in a Docker container.

### Releasing

The release process will push tags to GitHub, push the gem to rubygems and push the docker image to DockerHub.
Releasing is done manually, not by CI. The release process will push tags to GitHub, push the gem to rubygems and push the docker image to DockerHub.

Prerequisites:

* logged into dockerhub via `docker login`. Your user must have permission to push to `realestate/stackup`
* You must be logged into docker hub via `docker login`. Your user must have permission to push to `realestate/stackup`
* You must have a rubygems account with permission to push to the `stackup` gem. (`auto/release` will ask for your username and password)
* You must have cloned this repo via HTTPS and have a github account with permission to push. (`auto/release` will ask for your username and a GitHub personal access token)

Expand Down
11 changes: 11 additions & 0 deletions auto/dev-environment
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#! /bin/bash -e
#
# Run rake

cd $(dirname $0)/..

trap "docker-compose down --volumes" 0

docker volume create --name ruby2.6-bundle-cache > /dev/null
docker-compose run --rm dev sh -c 'bundle check > /dev/null || bundle install'
docker-compose run --rm dev bundle exec "${@-bash}"
8 changes: 8 additions & 0 deletions auto/test
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#! /bin/bash -eu
#
# Run tests

cd $(dirname $0)/..

echo "--- Running specs"
./auto/dev-environment rake spec
Loading