Update JS dependencies #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This should fix the github JS vulns warning
|
@davidfischer, it seems that |
|
I didn't actually check whether it was needed. I'll check if it is and remove it otherwise. Thanks for the tip. |
|
It is not used. I removed it! |
eine
approved these changes
Jan 15, 2020
|
Good! BTW, It would be handy to use david-dm and/or dependabot to keep dependencies up to date: |
Blendify
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the github JS vulns warning. I tested this by running
npm run devandnpm run buildto ensure that the JS still runs and compiles CSS/JS.