Move JS to bottom of page

[ehough]

Thought I'd try moving all the JS to the bottom of the page for performance purposes. Work fine in my testing. Curious to hear your feedback.

Thanks for this project!

[snide]

Thanks for the sub.

@ehough I'd rather not change the block names since they are the standard for Sphinx templates and as much as I don't like the way they have stuff setup, seems prudent to stick with convention.

@ericholscher Dunno how moving the JS to the bottom effects your loading in RTD. As I remember it, I tried something like this before, but your overwrites once it moved to RTD caused problems.

The JS being loaded is pretty minimal, so the gain isn't huge if that was/is the case.

[ericholscher]

I don't remember exactly what broke. I believe that as long as you keep the
extrahead block up top, it should work on RTD. I imagine it was just stuff
we were trying to inject into the page. Though I think we assume jquery
will be loaded, so that would probably break as well, and if you're loading
jquery in the top, then everything else is likely trivial size-wise. So, I
think thats why we ended up where we are.

On Sun, Jan 5, 2014 at 5:04 PM, Dave Snider notifications@github.comwrote:

Thanks for the sub.

@ehough https://github.com/ehough I'd rather not change the block names
since they are the standard for Sphinx templates and as much as I don't
like the way they have stuff setup, seems prudent to stick with convention.

@ericholscher https://github.com/ericholscher Dunno how moving the JS
to the bottom effects your loading in RTD. As I remember it, I tried
something like this before, but your overwrites once it moved to RTD caused
problems.

The JS being loaded is pretty minimal, so the gain isn't huge if that
was/is the case.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/78#issuecomment-31617093
.

Eric Holscher
Maker of the internet residing in Portland, Or
http://ericholscher.com

[ehough]

FWIW I don't see any jQuery-dependent JS in rtfd/readthedocs.org that is not addressed by this PR.

[ehough]

You can see a demo of this now at http://tubepress.readthedocs.org/en/latest/. Feel free to test at your convenience!

(it also includes #69)

[ericholscher]

Seems to work fine. I'm good with merging it.

[ericholscher]

Though we need to keep the block names to keep parity with Sphinx.

[ehough]

Thought I'd check in to see if we can get this PR merged.

Though we need to keep the block names to keep parity with Sphinx.

I addressed this in e16b8a8 by re-using Sphinx's footer block.

As a reminder, you can view a demo of this PR at http://docs.tubepress.com/

[snide]

Sorry, I've been busy and forgot about this one. I'll check this out now.

[snide]

K, checked out. Apologize for the long wait. Back in startup land so I'm back to hacking on the weekends with this.