-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated use of script_files #728
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this backwards compat? I believe it should be, but we should make sure to test it on Sphinx 1.8. |
ericholscher
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good assuming it's backwards compatible. 👍
Yes it is backwards compatible. |
4 tasks
Hi. Could you make a release, please? This issue is blocking us on several projects. Thanks. |
Closed
Merged
3 tasks
JulianGro
added a commit
to JulianGro/vircadia-docs-sphinx
that referenced
this pull request
Jan 29, 2021
JulianGro
added a commit
to JulianGro/vircadia-docs-sphinx
that referenced
this pull request
Feb 2, 2021
jtniehof
added a commit
to jtniehof/dbprocessing
that referenced
this pull request
Nov 18, 2021
* Handling of javascript mods for the html changed, wasn't going to work in 3.0. Basically copied fix from readthedocs/sphinx_rtd_theme#728 * This was used for the "hide prompts" feature in example code. New version still works in 1.6, but no longer in 1.5 or earlier. Docs still render fine, just don't have the "hide" button, so this is okay.
dnadeau-lanl
pushed a commit
to spacepy/dbprocessing
that referenced
this pull request
Nov 22, 2021
* Handling of javascript mods for the html changed, wasn't going to work in 3.0. Basically copied fix from readthedocs/sphinx_rtd_theme#728 * This was used for the "hide prompts" feature in example code. New version still works in 1.6, but no longer in 1.5 or earlier. Docs still render fine, just don't have the "hide" button, so this is okay.
9bow
added a commit
to PyTorchKorea/pytorch_sphinx_theme
that referenced
this pull request
Jun 30, 2022
9bow
added a commit
to PyTorchKorea/pytorch_sphinx_theme
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #725
Fixes sphinx-doc/sphinx#6088