Uglify during build #531
Uglify during build #531
Conversation
package.json
Outdated
| @@ -12,6 +12,7 @@ | |||
| "grunt-contrib-connect": "^1.0.2", | |||
| "grunt-contrib-copy": "~1.0.0", | |||
| "grunt-contrib-sass": "~1.0.0", | |||
| "grunt-contrib-uglify": "^3.3.0", | |||
There was a problem hiding this comment.
Maybe use a Tilda to match most other deps? Not really sure on this though. We should come up with a better policy for versions. @agjohnson @ericholscher How does RTD handle this?
There was a problem hiding this comment.
I think npm switched from using caret instead of tilde by default a while ago if you add a dependency using --save-dev.
Basically ^3.3.0 will upgrade to any 3.x.y but not to 4.0.0. ~3.3.0 will upgrade to any 3.3.y, but not to 3.4.y.
Since we're talking about semver, caret should be safe enough, but I'm fine with tilde if the extra safety is desired.
There was a problem hiding this comment.
I am fine with whatever, it just would be nice to keep consistency.
There was a problem hiding this comment.
I've changed it to tilde for consistency.
|
Unless someone has something else to add this can be merged
…On Dec 29, 2017 10:23 AM, "Jesse Tan" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In package.json
<#531 (comment)>:
> @@ -12,6 +12,7 @@
"grunt-contrib-connect": "^1.0.2",
"grunt-contrib-copy": "~1.0.0",
"grunt-contrib-sass": "~1.0.0",
+ "grunt-contrib-uglify": "^3.3.0",
I've changed it to tilde for consistency.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#531 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOeua6YWcZ3ioBBlTpLUworPcAD0fGUEks5tFQQDgaJpZM4ROJ1M>
.
|
|
This looks good to me. |
Adds an extra uglify task when running
grunt build.The symbol
jQueryis left as-is so other code may use this identifier if needed.IE6-8 compatibility is turned on just in case.
Fixes #527