Make Gruntfile more foolproof #518
Conversation
|
Why not remove modernizer during cleaning?
On Dec 20, 2017 4:47 AM, "Jesse Tan" <notifications@github.com> wrote:
@jessetan <https://github.com/jessetan> requested your review on:
readthedocs/sphinx_rtd_theme#518
<#518> Make Gruntfile more
foolproof.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#518 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AOeua8X9Czwi6QJ8fhAU5R0XWBLCswv3ks5tCNfLgaJpZM4RII2h>
.
|
|
Because Modernizr is only a committed file (probably downloaded from the website), it is not built by any grunt task. |
|
Why not do that then?
…On Wed, Dec 20, 2017 at 9:09 AM, Jesse Tan ***@***.***> wrote:
Because Modernizr is only a committed file, it is not built by any grunt
task.
It would be good to build one using https://github.com/Modernizr/
grunt-modernizr.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#518 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOeua1_dNF-EMd-lGzcgTZTmXHGeIBBWks5tCRT9gaJpZM4RII2h>
.
--
Aaron Carlisle
Picture taker | Bit cruncher | Pixel pusher | Document writer |
Project administrator for the Blender 3D Documentation Project
|
There was a problem hiding this comment.
LGTM, along with @Blendify's comment, which might be useful.
| @@ -160,6 +162,6 @@ module.exports = function(grunt) { | |||
| grunt.loadNpmTasks('grunt-browserify'); | |||
|
|
|||
| grunt.registerTask('fonts', ['clean:fonts','copy:fonts']); | |||
There was a problem hiding this comment.
I think grunt fonts should be removed
|
Is Modernizr actually used for anything? The only reasons I can think for keeping this is:
Perhaps we can consider removing Modernizr? I suggest we leave this PR as-is and do any changes related to Modernizr in a separate PR. |
|
👍 |
This should reduce some issues where incorrect files are committed or released:
copy:fontswhen building. Prevents issues with outdated or missing font files (no need to repeat Run grunt fonts #506 manually)