Finalized #418 #433
Merged
Finalized #418 #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor list items. * Use autonumbering in lists to prevent errors. * Indent code inside list items to make it belong to those items. * Use inline-code style for filenames. * Update link to a pull request with new repo path. * Fix a few typos and punctuation. * Use .. code:: bash for proper highlighting * Use # for comments in bash * Use ordered list for step-by-step instuctions.
|
Oh yeah, this also fixes the merge issue in #418, that's why I didn't PR against the original PR branch :) |
Blendify
approved these changes
Jun 17, 2017
travismiller
pushed a commit
to broco1974/couscous-template-readthedocs
that referenced
this pull request
Dec 4, 2017
* commit '6c2302472fb2c61eec9b4be3a2515117fffbfac3': (253 commits) Add pygments_style to theme.conf Document new theme option Add option to layout.html Update theme.conf Apply clearfix on breadcrumbs Follow-up grunt for readthedocs#472 (readthedocs#476) Only change current if a matching link is found (readthedocs#472) Add a couple of badge icons to readme (readthedocs#471) Add Sphinx Framework for PyPi (readthedocs#470) Fix error in setup entry points (readthedocs#466) Added `.admonition` to the CSS (readthedocs#462) Use explicit UTF8 encoding (readthedocs#452) Add missing pygments css link Convert underscores to dashes. Reflect language in lang attribute. Replace master with v0.2.5 in README.rst Add missing dependency in dev setup: sphinxcontrib-httpdomain (readthedocs#431) Finalized readthedocs#418 (readthedocs#433) Added a link to the Sphinx documentation about setuptools entry points Added setuptools entry point for Sphinx ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finalizes comments regarding indents by @agjohnson on #418
In an ideal world where everyone knows exactly what's the most efficient thing to do, #418 would have just had PRs against @NickVolynkin branch rather than all the comments about indentation back and forth :)
(please don't regard the above as some smart-ass comment, I'm trying also to teach myself to spend less time commenting and more time PRing in other reviews, and I know it's hard because I fear getting sucked in and ending up spending half the evening with someone elses PR)