Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forcing of image size on badge. #365

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Remove forcing of image size on badge. #365

merged 2 commits into from
Mar 2, 2017

Conversation

ericholscher
Copy link
Member

This is a really weird thing to do in our badge CSS.
It makes badges show up 100% width on sites that use our badge,
which seems like a broken thing.

This is a really weird thing to do in our badge CSS.
It makes badges show up 100% width on sites that use our badge,
which seems like a broken thing.
@ericholscher ericholscher requested a review from agjohnson March 2, 2017 21:56
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, but the failure case isn't clear from just looking at the code. Any examples?

@ericholscher
Copy link
Member Author

ericholscher commented Mar 2, 2017

screenshot 2017-03-02 15 14 58

http://docs.python-requests.org/en/master/ on a mobile display :)

@agjohnson
Copy link
Collaborator

Ooo pretty. Yeah, this fix looks good then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants