Drop dependency on Sphinx #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
added a commit
that referenced
this pull request
Jan 12, 2016
Drop dependency on Sphinx
|
Thanks! |
|
Thanks guys. And this just works for you without doing anything else? |
|
@ericholscher: Thanks for merging it! @jakirkham: It works for us in Debian (we have been shipping this patch for quite some time now), though I don't quite understand what your question is about. |
|
@mitya57, ok, I was just asking because I didn't know if there were imports that needed to be changed or other things. However, it doesn't look like |
|
Right, sphinx is not imported anywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @birkenfeld in #189, this is the easiest way to solve the dependency loop that is creating problems for packagers. Fixes #189.