Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled collapse_navigation stops working when sticky_navigation is also disabled #481

Closed
drrosa opened this issue Nov 8, 2017 · 1 comment

Comments

@drrosa
Copy link

drrosa commented Nov 8, 2017

How come these two settings don't work when both are set to false?

html_theme_options = {
     'collapse_navigation': False,
     'sticky_navigation': False,
}

'collapse_navigation': False and 'sticky_navigation': True allows the user to collapse/expand all items in the sidebar. Which is what I want.

However, I do not want the sticky nav bar. But when I set 'sticky_navigation': False, all the little + signs that allow the user to collapse/expand items simply go away as if 'collapse_navigation' was set to True.

Is there a way to have collapsible navigation items without a sticky nav bar?

jessetan added a commit that referenced this issue Dec 20, 2017
This used to depend on the sticky nav being enabled.
Fixes #481
@jessetan
Copy link
Contributor

This is not working because the navigation JS code is only activated when sticky nav is enabled. If sticky nav is disabled, the toggles to expand navigation are not added.
PR #519 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants