Better JavaScript syntax highlighting

[TimKam]

The Sphinx Read the Docs theme could do better in highlighting JavaScript code:

Sphinx/Pygments already provides the necessary classes:

So this should be merely a matter of adding additional styles.

If this makes sense to you, I could try to find the time for creating a PR.

[Blendify]

PRs are welcome anytime.

[ericholscher]

Yep, this would be a great addition!

[ghost]

@TimKam What Atom UI/Syntax do you use?

[Blendify]

#448 should fix this.

[skaller]

Could I have some feedback on this please? In my case, it isn't JS that's the problem, but other Pygments lexers. With "classic" html_theme the colours are strong, the bolding good, and the sizes slightly bigger, and the background different from RTD. I don't mind the size change or background difference much, but the Pygments colours are basically clobbered.

The bolding is unnoticeable and almost all the colour is bled away, except the disgusting bright red used for string literals.

This is running the online version of RTD. Shouldn't the theme respect the Pygments colours?

The problem I have is that the tokenisation scheme used doesn't really fit my language or what I want to see, so I have to fudge a bit to get the appearance right, but nothing works on RTD.

My language (Felix) isn't the only one impacted. C++ code is similarly impacted. Comments get faded to almost unreadable status, colour is bled away.

[Blendify]

The reason this does not work is that the HTML is not aware of the Pygments CSS #448 was going to fix this but this change is now included in a larger set of changes that can be found in this PR: #467. There are two temp fixes:

1. Use pip install git+https://github.com/rtfd/sphinx_rtd_theme.git@6da7eb974754582353e80eada1151751745e185c

2. Add http://www.sphinx-doc.org/en/stable/extdev/appapi.html#sphinx.application.Sphinx.add_stylesheet to the conf.py to link the css file manually.

[skaller]

Ok thanks!

actually I used a a <style> tag in a _template/layout.html and that seemed to work. The template gets injected after the main css is linked so it overrides it.

[Blendify]

Basic support for this has been added and #504 finishes this up. Closing.