Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 1400px media-query to 1100px ? #305

Closed
Carreau opened this issue Jun 27, 2016 · 1 comment
Closed

Move 1400px media-query to 1100px ? #305

Carreau opened this issue Jun 27, 2016 · 1 comment
Assignees
@ericholscher @agjohnson @Blendify
Labels
PR: work in progress Pull request is not ready for full review

Comments

@Carreau
Copy link
Contributor

Carreau commented Jun 27, 2016

The .wy-nav-content wraps at 1100px width when above 1400px+ wide, and has a linear growth until this value, which make the website "jump" when you reach the 1400px width threshold.

Which is then weid as a 1401px wide window has narrower content than a 1399 one...

I think the theme should either move the 1400px transition to 1100px. THen the content just "stop growing", or change the max-width of wy-nav-content to be higher by 300px.

Both looks fine. I can likely make a PR depending on the one you prefer.
@Blendify Blendify added the Needed: design decision A core team decision is required label Mar 9, 2017
@Blendify
Copy link
Member

Personally, I think that we should extend the width by 200px and decrease the media query by 100px? We should also when fixing this write a function so this can be changed easier.

@Blendify Blendify mentioned this issue Mar 14, 2017
Merged
@agjohnson agjohnson added PR: work in progress Pull request is not ready for full review and removed Needed: design decision A core team decision is required labels Mar 14, 2017
Blendify added a commit that referenced this issue Jan 25, 2018
@Blendify
Fix #305 Move 1400px media-query to 1100px (#396)
419c6f5 
* Use sass var for content max width

* Add new theme vars

* Use own media screen

* Update patch with the ability to chnage the side bar width and content width

There is still a bug were the centent width fills the full screen.
This will have to be fixed before merging.

* Use javascript instead

* Run grunt build

* Remove the ability to set sidebar width

* Revert "Remove the ability to set sidebar width"

This reverts commit 3ad5b5b.

* Revert "Run grunt build"

This reverts commit f3f9ff9.

* Revert "Use javascript instead"

This reverts commit 630b50f.

* Revert "Update patch with the ability to chnage the side bar width and content width"

This reverts commit f928c33.
emilyemorehouse added a commit to cuttlesoft/sphinx_rtd_theme that referenced this issue Mar 6, 2018
@emilyemorehouse
Merge branch 'rtfd/master'
b949e42 
* rtfd/master: (252 commits)
  Docs: restructure (readthedocs#573)
  Docs: Fix typos (readthedocs#584)
  add missing quotes (bottom should be a string) (readthedocs#580)
  Typo: Contibuting => Contributing
  Allow versions popup to scroll (readthedocs#576)
  Add document block and rename bodycontent content
  Add a block around the page content
  Docs: httpdomain package name uses dash instead of period
  Update changlog for 0.2.5 (readthedocs#570)
  Run Grunt (readthedocs#568)
  Create CODE_OF_CONDUCT.md (readthedocs#562)
  readthedocs#463 - Add github, gitlab, bitbucket page arguments option (readthedocs#464)
  Remove from theme.conf
  Remove from docs
  Update footer.html (readthedocs#561)
  Refactor docs: split up & slim down read me
  Fix readthedocs#305 Move 1400px media-query to 1100px  (readthedocs#396)
  Only output div.articleComments if the block has content (readthedocs#555)
  Readme cleanup (readthedocs#554)
  Add GitHub templates (readthedocs#410)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericholscher ericholscher

@agjohnson agjohnson

@Blendify Blendify

Labels
PR: work in progress Pull request is not ready for full review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ericholscher @Carreau @agjohnson @Blendify