Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flag: remove DONT_SHALLOW_CLONE #10588

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 1, 2023

This can be done now by using build.jobs.post_checkout. See an example at https://docs.readthedocs.io/en/latest/build-customization.html#unshallow-git-clone

@humitos humitos added the Status: blocked Issue is blocked on another issue label Aug 1, 2023
@humitos humitos requested a review from a team as a code owner August 1, 2023 10:37
@humitos humitos requested a review from stsewd August 1, 2023 10:37
@humitos
Copy link
Member Author

humitos commented Aug 1, 2023

We said we will be removing this feature on August 28th. So we should merge it that day.

@humitos humitos enabled auto-merge (squash) August 22, 2023 17:53
@humitos humitos removed the Status: blocked Issue is blocked on another issue label Aug 22, 2023
@humitos humitos disabled auto-merge August 22, 2023 20:12
@humitos
Copy link
Member Author

humitos commented Aug 22, 2023

Check test failing is unrelated to this PR.

@humitos humitos merged commit 200f9a8 into main Aug 22, 2023
@humitos humitos deleted the humitos/remove-dont-shallow-clone branch August 22, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants