Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: deprecated notification for projects without config file #10354

Merged
merged 33 commits into from
Jun 6, 2023
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
ded4fab
Config: deprecated notification for builds without config file
humitos May 25, 2023
931ba62
Test: invert logic
humitos May 25, 2023
a623ac6
Notification's copy: feedback from review
humitos May 29, 2023
1c688b4
It's a function
humitos May 29, 2023
22eee3c
Notifications: use a scheduled Celery task to send them
humitos May 29, 2023
035c81f
Feedback from the review
humitos May 31, 2023
0a4156f
Darker failed on CircleCI because of this
humitos May 31, 2023
d78b3c4
Merge branch 'main' into humitos/build-without-config-deprecation
humitos May 31, 2023
4044819
Links pointing to blog post
humitos May 31, 2023
ee79a66
Merge branch 'humitos/build-without-config-deprecation' of github.com…
humitos May 31, 2023
acea9fc
Add more logging for this task
humitos May 31, 2023
f4831d6
Space typo
humitos May 31, 2023
d96f651
Ignore projects that are potentially spam
humitos May 31, 2023
400214f
Order queryset by PK so we can track it
humitos May 31, 2023
50d10bd
Improve query a little more
humitos May 31, 2023
3ba5cbb
Make the query to work on .com as well
humitos May 31, 2023
8889103
Query only active subscriptions on .com
humitos Jun 1, 2023
f85bf2c
Consistency on naming
humitos Jun 1, 2023
27e08ab
Only check for `Project.default_version`
humitos Jun 1, 2023
aa91651
Log progress while iterating to know it's moving
humitos Jun 1, 2023
0a17b24
Simplify versions query
humitos Jun 1, 2023
c294d76
More logging to the progress
humitos Jun 1, 2023
e2a78fe
Send only one notification per user
humitos Jun 1, 2023
094bf89
Modify email template to include all the projects and dates
humitos Jun 1, 2023
e244371
Typo
humitos Jun 1, 2023
98941e5
Improve logging
humitos Jun 1, 2023
4fb54f0
Keep adding logging :)
humitos Jun 1, 2023
7bda672
Db query for active subscriptions on .com
humitos Jun 6, 2023
e42e9c6
Email subject
humitos Jun 6, 2023
8dbbf6e
Update onsite notification message
humitos Jun 6, 2023
136da2b
Do not set emails just yet
humitos Jun 6, 2023
5d7f42c
Minor updates
humitos Jun 6, 2023
0a947a1
Update emails with new dates
humitos Jun 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
It's a function
  • Loading branch information
humitos committed May 29, 2023
commit 1c688b4b61375cbbbdaeeb441ef0842ebbdd6b18
2 changes: 1 addition & 1 deletion readthedocs/projects/tasks/utils.py
Original file line number Diff line number Diff line change
@@ -197,7 +197,7 @@ def deprecated_config_file_used_notification(build_pk):
since we don't have access to the db from the build.
"""
build = Build.objects.filter(pk=build_pk).first()
if not build or not build.deprecated_config_used:
if not build or not build.deprecated_config_used():
return

log.bind(