Docs: Experiment with canonical url using READTHEDOCS_CANONICAL_URL #10224
Conversation
|
PR has correct meta tag defined 👍 https://docs--10224.org.readthedocs.build/en/10224/ |
There was a problem hiding this comment.
Great!
This is a quick experiment: I noticed that all the canonical meta tags on all versions of the Jupyter Notebook are almost definitely wrong.. they point to /stable meaning that you cannot generate accurate link previews.
Does it make sense to open a PR in their repository with these changes?
It does 👍 I shared a pointer to this PR, hoping that some Jupyter people would be interested in adding this to their various projects 👍 If we have a couple of successful implementations of this, we can start tracking them in an issue to use |
As noted in readthedocs/readthedocs.org#10224 with the current configuration the canonical URL is wrong with different sphinx builds. For instance the "latest" docs point to "stable". This leads to apps like Mastodon to generate previews to pages which don't exist since they rely on <link rel="canonical" href="https://jupyter-notebook.readthedocs.io/en/stable/notebook_7_features.html" /> This should fix that.
As noted in readthedocs/readthedocs.org#10224 with the current configuration the canonical URL is wrong with different sphinx builds. For instance the "latest" docs point to "stable". This leads to apps like Mastodon to generate previews to pages which don't exist since they rely on <link rel="canonical" href="https://jupyter-notebook.readthedocs.io/en/stable/notebook_7_features.html" /> This should fix that.
* Use correct canonical URL while building docs (#6829) As noted in readthedocs/readthedocs.org#10224 with the current configuration the canonical URL is wrong with different sphinx builds. For instance the "latest" docs point to "stable". This leads to apps like Mastodon to generate previews to pages which don't exist since they rely on <link rel="canonical" href="https://jupyter-notebook.readthedocs.io/en/stable/notebook_7_features.html" /> This should fix that. * Renaming migration file to `migrating_to_notebook7` * Use the correct name * fix ref --------- Co-authored-by: Ashwin V. Mohanan <9155111+ashwinvis@users.noreply.github.com>
This is a quick experiment: I noticed that all the canonical meta tags on all versions of the Jupyter Notebook are almost definitely wrong.. they point to /stable meaning that you cannot generate accurate link previews.
Take for instance this build: https://readthedocs.org/projects/jupyter-notebook/builds/19683327/
The solution is to use our new environment variable 🎉