Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxito v2: Finish v2 migration and remove old implementation #10408

Closed
ericholscher opened this issue Jun 7, 2023 · 1 comment · Fixed by #10660
Closed

Proxito v2: Finish v2 migration and remove old implementation #10408

ericholscher opened this issue Jun 7, 2023 · 1 comment · Fixed by #10660
Assignees
@stsewd

Comments

@ericholscher
Copy link
Member

ericholscher commented Jun 7, 2023 •
edited
Loading

Now that the initial Proxito v2 prefix work is merged, we want to finish up the work to deprecate the old version:

  • Migrate existing projects to the new proxito implementation using custom prefixes.
  • Roll out the new implementation to everyone (.com, since .org is already using the new implementation)
  • Remove old code and use one single entry point for the serve docs view.

Refs #10181 #10307

Originally posted by @stsewd in #9911 (comment)
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Jun 7, 2023
@ericholscher ericholscher moved this from Planned to In progress in 📍Roadmap Jun 7, 2023
@ericholscher ericholscher changed the title Proxito next next steps :D Proxito: Finish v2 migration and remove old implementation Jun 7, 2023
@ericholscher ericholscher moved this from In progress to Planned in 📍Roadmap Jun 7, 2023
@ericholscher ericholscher changed the title Proxito: Finish v2 migration and remove old implementation Proxito v2: Finish v2 migration and remove old implementation Jun 7, 2023
@ericholscher ericholscher mentioned this issue Jun 7, 2023
Closed
@stsewd stsewd moved this from Planned to In progress in 📍Roadmap Jul 5, 2023
stsewd added a commit that referenced this issue Aug 14, 2023
@stsewd
Proxito: allow to generate proxied API URLs with a prefix

Verified

This commit was signed with the committer’s verified signature.
stsewd Santos Gallegos
GPG key ID: C1AD42C27116CB5A
Verified
Learn about vigilant mode
fc3b4df 
- Ref #10181
- Ref #10408
- Ref readthedocs/meta#124
@stsewd stsewd mentioned this issue Aug 14, 2023
Merged
stsewd added a commit that referenced this issue Aug 15, 2023
@stsewd
Proxito: allow to generate proxied API URLs with a prefix (#10634)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2c6a064 
- Ref #10181
- Ref #10408
- Ref readthedocs/meta#124
@stsewd stsewd mentioned this issue Aug 23, 2023
Merged
@stsewd stsewd moved this from In progress to Needs review in 📍Roadmap Aug 23, 2023
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Aug 28, 2023
stsewd added a commit that referenced this issue Aug 28, 2023
@stsewd
Proxito: remove old implementation (#10660)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
40bfe63 
Mostly removing old code, there is only one small custom addition

https://github.com/readthedocs/readthedocs.org/blob/6595bdac198b482e1279c0e3b1925198f6baa631/readthedocs/proxito/views/serve.py#L144-L146

Django doesn't capture the first slash, previously we were getting the path from request.path_info, that includes the slash! When a request is done to `/` the path is set to "" (empty), our code relies on that being `/`.

- Closes #10408
- Closes #8399

### How to deploy this change

- Deploy everything as usual, but don't run the `projects 0105` migration!!!
- After deploy is done, run the `projects 0105`  migration
@ericholscher
Copy link
Member Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stsewd stsewd

Labels
None yet
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Proxito: remove old implementation readthedocs/readthedocs.org
2 participants
@ericholscher @stsewd