Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"canonical" URL should be escaped #82

Closed
mgeier opened this issue Apr 18, 2020 · 0 comments · Fixed by #93
Closed

"canonical" URL should be escaped #82

mgeier opened this issue Apr 18, 2020 · 0 comments · Fixed by #93

Comments

@mgeier
Copy link

mgeier commented Apr 18, 2020

If the URL happens to have " in it, the URL becomes invalid.
This was referenced Apr 18, 2020
Closed
Merged
stsewd added a commit that referenced this issue Oct 6, 2020
@stsewd
Canonical URL: don't set it if is empty
02f7750 
Fix #82

Ref #83

We need to release the extension first, make sure all builds are using
that version and then release readthedocs/readthedocs.org#7540
@stsewd stsewd mentioned this issue Oct 6, 2020
Merged
@stsewd stsewd closed this as completed in #93 Oct 6, 2020
stsewd added a commit that referenced this issue Oct 6, 2020
@stsewd
Canonical URL: don't set it if is empty
f32bef5 
Fix #82

Ref #83

We need to release the extension first, make sure all builds are using
that version and then release readthedocs/readthedocs.org#7540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Canonical URL: don't set it if is empty readthedocs/readthedocs-sphinx-ext
1 participant
@mgeier