Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action.yaml: fix message-template #32

Closed
wants to merge 1 commit into from

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Dec 2, 2023

The message template contains four dashes,
and that apparently makes Github not render
the following books emoji. Use three dashes
instead.

The non-displaying emojis can be seen in #12,
or #16 for something more recent.


📚 Documentation preview 📚 : https://readthedocs-preview--32.org.readthedocs.build/en/32/

The message template contains four dashes,
and that apparently makes Github not render
the following books emoji. Use three dashes
instead.
@pjonsson
Copy link
Contributor Author

pjonsson commented Dec 2, 2023

This requires #33 to be merged before passing the CI.

@Jamim
Copy link

Jamim commented Dec 10, 2023

Hello @pjonsson,
Thank you for the fix! 🙇🏻‍♂️

For the sake of transparency:

@humitos
Copy link
Member

humitos commented Dec 11, 2023

Testing triple dash rendering here...


... continues here.

@humitos
Copy link
Member

humitos commented Dec 11, 2023

Checking if it works in the same way as four dashes...


... continues here.

@humitos
Copy link
Member

humitos commented Dec 11, 2023

Checking again...

... continues here.

@humitos
Copy link
Member

humitos commented Dec 11, 2023

Checking again...

... continues here.

@humitos
Copy link
Member

humitos commented Dec 11, 2023

Checking again...

📚: continues here.

@humitos
Copy link
Member

humitos commented Dec 11, 2023

Checking again...

📚: continues here.

@humitos
Copy link
Member

humitos commented Dec 11, 2023

I did some tests here and I wasn't able to reproduce the issue. Please, see #34 (comment) to see how we continue moving forward.

@pjonsson
Copy link
Contributor Author

I did some tests here and I wasn't able to reproduce the issue. Please, see #34 (comment) to see how we continue moving forward.

Not being able to reproduce seems concerning. Here's a screenshot of this PR from my screen:

image

The lower left corner contains the characters "books" between colons, rather than an emoji of books, so this repository is still affected for at least some of us.

@humitos
Copy link
Member

humitos commented Dec 11, 2023

The lower left corner contains the characters "books" between colons, rather than an emoji of books, so this repository is still affected for at least some of us.

I see the same here. I tried editing the description to remove a - and I was not able to make it work 🤷🏼

@humitos
Copy link
Member

humitos commented Dec 11, 2023

Also, I don't know why it started to failed now. I was working before. So, GitHub has changed something?

@pjonsson
Copy link
Contributor Author

Your main repository uses a custom message, so you don't see the issue there. (That is where I found the solution to the problem.)

#12 is from August 2022, so it's been around for a while.

I did this PR 9 days ago so I don't remember when you added the XML comment to keep track of the URL, but it's possible that is what caused things to break.

@pjonsson
Copy link
Contributor Author

Even if this PR is wrong, could you check/reject-and-make-some-other-fix #33 first so PRs to this repository aren't automatically red?

humitos added a commit that referenced this pull request Dec 12, 2023
@humitos humitos closed this in #37 Dec 12, 2023
humitos added a commit that referenced this pull request Dec 12, 2023
@humitos
Copy link
Member

humitos commented Dec 12, 2023

I merged #37 which uses the real emoji instead of :books:. After opening a new PR #38 I can see the emojis properly rendered there. @egeakman @pjonsson let me know if it works for you.

@pjonsson pjonsson deleted the fix-emoji-display branch December 12, 2023 09:35
@pjonsson
Copy link
Contributor Author

Strange, my first attempt at fixing this was identical to your PR, but didn't work for some reason.

It works now though, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants