-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action.yaml: fix message-template #32
Conversation
The message template contains four dashes, and that apparently makes Github not render the following books emoji. Use three dashes instead.
This requires #33 to be merged before passing the CI. |
Hello @pjonsson, For the sake of transparency:
|
Testing triple dash rendering here... ... continues here. |
Checking if it works in the same way as four dashes... ... continues here. |
Checking again...... continues here. |
Checking again...... continues here. |
Checking again...📚: continues here. |
Checking again...📚: continues here. |
I did some tests here and I wasn't able to reproduce the issue. Please, see #34 (comment) to see how we continue moving forward. |
Not being able to reproduce seems concerning. Here's a screenshot of this PR from my screen: The lower left corner contains the characters "books" between colons, rather than an emoji of books, so this repository is still affected for at least some of us. |
I see the same here. I tried editing the description to remove a |
Also, I don't know why it started to failed now. I was working before. So, GitHub has changed something? |
Your main repository uses a custom message, so you don't see the issue there. (That is where I found the solution to the problem.) #12 is from August 2022, so it's been around for a while. I did this PR 9 days ago so I don't remember when you added the XML comment to keep track of the URL, but it's possible that is what caused things to break. |
Even if this PR is wrong, could you check/reject-and-make-some-other-fix #33 first so PRs to this repository aren't automatically red? |
Strange, my first attempt at fixing this was identical to your PR, but didn't work for some reason. It works now though, thanks! |
The message template contains four dashes,
and that apparently makes Github not render
the following books emoji. Use three dashes
instead.
The non-displaying emojis can be seen in #12,
or #16 for something more recent.
📚 Documentation preview 📚 : https://readthedocs-preview--32.org.readthedocs.build/en/32/