Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support single version projects #14

Closed
ericholscher opened this issue Oct 5, 2022 · 1 comment · Fixed by #16
Closed

Support single version projects #14

ericholscher opened this issue Oct 5, 2022 · 1 comment · Fixed by #16
Assignees
@ericholscher

Comments

@ericholscher
Copy link
Member

This should probably be hitting our API to get an unresolved URL for the project, but for now, an option that is single_version or similar would be good. It's breaking the links in the WTD builds because we have a single_version there.
@ericholscher
Copy link
Member Author

We hit this again on site-community. Probably worth adding to a sprint.

@ericholscher ericholscher moved this to Planned in 📍Roadmap Nov 10, 2022
ericholscher added a commit that referenced this issue Nov 21, 2022
@ericholscher
Add single_version config to fix URLs.
f410764 
Fixes #14
@ericholscher ericholscher mentioned this issue Nov 21, 2022
Merged
@ericholscher ericholscher moved this from Planned to In progress in 📍Roadmap Nov 23, 2022
@humitos humitos assigned ericholscher and unassigned humitos Nov 28, 2022
ericholscher added a commit that referenced this issue Nov 28, 2022
@ericholscher @humitos
Add single_version config to fix URLs. (#16)
cfdc433 
* Add single_version config to fix URLs.

Fixes #14

* Fix logic

* Use var properly

* Set RTD_SINGLE_VERSION

* Apply suggestions from code review

Co-authored-by: Manuel Kaufmann <humitos@gmail.com>

* Update preview/README.md

Co-authored-by: Manuel Kaufmann <humitos@gmail.com>

Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Repository owner moved this from In progress to Done in 📍Roadmap Nov 28, 2022
humitos added a commit that referenced this issue Jan 30, 2023
@ericholscher @humitos
Add single_version config to fix URLs. (#16)
66ede09 
* Add single_version config to fix URLs.

Fixes #14

* Fix logic

* Use var properly

* Set RTD_SINGLE_VERSION

* Apply suggestions from code review

Co-authored-by: Manuel Kaufmann <humitos@gmail.com>

* Update preview/README.md

Co-authored-by: Manuel Kaufmann <humitos@gmail.com>

Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericholscher ericholscher

Labels
None yet
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add single_version config to fix URLs. readthedocs/actions
2 participants
@ericholscher @humitos