Improve error messages for failed TCP/IP connections with errno/errstr #265
+46
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Aug 8, 2021
This was referenced Aug 11, 2021
This was referenced Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset improves the error messages for failed TCP/IP connections to include the appropriate errno/errstr. Whereas it would previously report a generic "Connection refused" error, it will now report the actual underlying error condition, such as this:
$ telnet 192.168.0.1 8080 Trying 192.168.0.1... telnet: Unable to connect to remote host: Network is unreachable $ php examples/11-http-client.php 192.168.0.1 RuntimeException: Connection to tcp://192.168.0.1:80 failed: Network is unreachable in …/TcpConnector.php:115Builds on top of #171, reactphp/dns#171, reactphp/dns#172 and others