Improve test suite to exclude TLS 1.3 tests on PHP 7.3 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59e524b to
bca0f77
Compare
Explicit TLS 1.3 support will be available in PHP 7.4: php/php-src#3909 Older PHP versions implicitly support TLS 1.3 provided that the underlying OpenSSL version supports TLS 1.3. However, for PHP 7.3 some recent changes implicitly disable TLS 1.3, so we skip TLS 1.3 tests on affected PHP versions: php/php-src#3317
bca0f77 to
198690e
Compare
WyriHaximus
approved these changes
Nov 17, 2019
jsor
approved these changes
Nov 17, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit TLS 1.3 support will be available in PHP 7.4: php/php-src#3909
Older PHP versions implicitly support TLS 1.3 provided that the
underlying OpenSSL version supports TLS 1.3. However, for PHP 7.3 some
(not so) recent changes implicitly disable TLS 1.3, so we skip TLS 1.3 tests on
affected PHP versions: php/php-src#3317
Builds on top of #186, #201 and #202
Noticed this due to a build error while working on reactphp/reactphp#432