Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example 99 improvements #190

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Example 99 improvements #190

merged 2 commits into from
Jan 24, 2019
+1 −1

Conversation

jsor
Copy link
Member

@jsor jsor commented Jan 22, 2019

Minor fixes and improvements for examples/99-generate-self-signed.php discovered in #189

clue
clue reviewed Jan 23, 2019
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This repo still has a localhost_swordfish.pem and a number of references to this in the tests, do you think this should be updated as part of this PR? 👍

@jsor
Copy link
Member Author

jsor commented Jan 24, 2019

@clue Yes, i noticed that as well. But i didn't find any direct references to this script. It's still possible to generate a cert with the password swordfish.

@clue
Copy link
Member

clue commented Jan 24, 2019

@jsor Good, no objections then 👍

@clue clue merged commit 2cf8dfa into reactphp:master Jan 24, 2019
@clue clue added this to the v1.2.1 milestone May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jsor @clue @WyriHaximus