-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward compatibility with upcoming Promise v3 #460
Conversation
Rebased to fix merge conflict now that #464 has been merged. There are still a couple of failing tests that look like some unexpected behavior changes in Promise v3 as also noticed by @WyriHaximus in reactphp/socket#214 (comment). Considering the HTTP component depends on the Socket component, let's continue this discussion in the upstream PR. I'll make sure to update this PR once we make progress. |
Updated to use Socket v1.12.0 and apply the same changes to fix a race in the tests as discussed in reactphp/socket#214 (comment), so the build should now be green. This is still WIP as this currently still depends on updated dev dependencies that I'll try to get shipped no later than next week. |
a0399bd
to
78cfb44
Compare
Updated to stable releases now that all dependencies have been released:
Also worked around another nasty HHVM build error because legacy HHVM does not support the This is now ready for review |
Builds on top of reactphp/promise#75, reactphp/promise#213, reactphp/promise#138, reactphp/socket#214 and reactphp/promise-stream#20
Also builds on top of dev updates in clue/reactphp-block#61, clue/reactphp-http-proxy#44, clue/reactphp-socks#106 and clue/reactphp-ssh-proxy#35