gzip and deflate content encoding decoding #50
Conversation
| @@ -238,11 +238,15 @@ public function setResponseFactory($factory) | |||
| $this->responseFactory = $factory; | |||
| } | |||
|
|
|||
| public function getResponseFactory() | |||
| public function getResponseFactory($psrResponse = null) | |||
There was a problem hiding this comment.
I'm not very fond of solving it this way, any suggestions to do it better then this are very welcome
|
I'd love to see this feature in, but I'm unsure about its current state tbh. What do you think about https://github.com/clue/php-zlib-react#inconsistencies? Also, we should evaluate how the returned body contents plus related headers are presented to consumers of this lib and whether we should consider this a BC break. I'd love to hear some more thoughts on this before diving into a deeper code review 👍 |
| 'User-Agent' => 'React/alpha', | ||
| 'Host' => $this->getHost().$port, | ||
| 'User-Agent' => 'React/alpha', | ||
| 'Accept-Encoding' => 'gzip', |
|
As much as I'd love to get this feature in, I'm having to close this for now as it hasn't received any input in a while and it's unlikely this will get traction any time soon. The feature request is still open in #37 and we may look into this again in the future 👍 If you feel this was closed prematurely or want to pick this up again, please let us know and we can reopen this. Thank you for your effort! |
Using
clue/zlib-reactthis PR adds gzip and deflate content encoding decoding and paves the way chunked encoding decoding and the likes of it.Fixes #30