Use connect($uri)
instead of create($host, $port)
#74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines dedicated
$host
and$uri
parameters into a single$uri
. This is obviously a BC break, so let's rename the method to a more meaningful name while we're at it.There are plenty of reasons, let me try to list a few here:
UnixConnector
currently has an unused$port
parameterSee also the individual commits if you want to review the changes.