Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use connect($uri) instead of create($host, $port) #74

Merged
merged 4 commits into from
Jan 9, 2017

Conversation

clue
Copy link
Contributor

@clue clue commented Dec 2, 2016

This PR combines dedicated $host and $uri parameters into a single $uri. This is obviously a BC break, so let's rename the method to a more meaningful name while we're at it.

There are plenty of reasons, let me try to list a few here:

See also the individual commits if you want to review the changes.

@clue
Copy link
Contributor Author

clue commented Dec 19, 2016

Rebased now that #72 is in :shipit:

Copy link
Contributor

@jsor jsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants