Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate lifo() vs fifo() distinction, preparing to remove lifo() flavor #94

Closed
simonbasle opened this issue Aug 5, 2020 · 1 comment
Closed

Deprecate lifo() vs fifo() distinction, preparing to remove lifo() flavor #94

simonbasle opened this issue Aug 5, 2020 · 1 comment
Assignees
@simonbasle
Labels
type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations
Milestone
0.1.6.RELEASE

Comments

@simonbasle
Copy link
Contributor

Motivation

The lifo() flavor was introduced after misinterpreting a requirement, since clarified in #87.
I don't think it is actually that terribly useful to serve pending acquire() in a LIFO order.

If you have an actual use case for LIFO order of acquire (and not of idle resources), please comment on this issue.

As a reminder, the lifo() flavor means that when the pool is empty and no more resources can be created, an acquire is parked in a stack instead of a queue. And so, the next time a resource is released, the most recently parked acquire will be unparked and served.
@simonbasle simonbasle added this to the 0.1.6.RELEASE milestone Aug 5, 2020
@simonbasle simonbasle self-assigned this Aug 5, 2020
@reactorbot reactorbot added the ❓need-triage This issue needs triage, hasn't been looked at by a team member yet label Aug 5, 2020
@simonbasle simonbasle added warn/deprecation This issue/PR introduces deprecations type/enhancement A general enhancement and removed ❓need-triage This issue needs triage, hasn't been looked at by a team member yet labels Aug 5, 2020
simonbasle added a commit that referenced this issue Aug 5, 2020
@simonbasle
fix #94 Deprecate fifo vs lifo distinction, preparing to remove lifo
dc46984
@simonbasle simonbasle mentioned this issue Aug 5, 2020
Merged
simonbasle added a commit that referenced this issue Aug 6, 2020
@simonbasle
fix #94 Deprecate fifo vs lifo distinction, preparing to remove lifo
473f221
@simonbasle
Copy link
Contributor Author

This was merged into master via c23169d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations
Projects
None yet
Milestone
0.1.6.RELEASE
Development

No branches or pull requests
2 participants
@simonbasle @reactorbot