Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #430 Defer decision for DefaultFileRegion vs ChunkedInput #451

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

violetagg
Copy link
Member

When NettyOutbound#sendFile, defer the decision for
DefaultFileRegion vs ChunkedInput

When NettyOutbound#sendFile, defer the decision for
DefaultFileRegion vs ChunkedInput
@violetagg violetagg requested a review from smaldini October 5, 2018 18:14
@violetagg violetagg added this to the 0.7.10.RELEASE milestone Oct 5, 2018
@codecov-io
Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #451 into 0.7.x will decrease coverage by <.01%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##              0.7.x     #451      +/-   ##
============================================
- Coverage     68.39%   68.39%   -0.01%     
+ Complexity     1057     1055       -2     
============================================
  Files            73       73              
  Lines          4518     4521       +3     
  Branches        656      655       -1     
============================================
+ Hits           3090     3092       +2     
+ Misses         1041     1040       -1     
- Partials        387      389       +2
Impacted Files Coverage Δ Complexity Δ
...or/ipc/netty/http/server/HttpServerOperations.java 67.72% <ø> (-1.03%) 54 <0> (-4)
...in/java/reactor/ipc/netty/http/HttpOperations.java 68.83% <ø> (ø) 22 <0> (ø) ⬇️
src/main/java/reactor/ipc/netty/NettyOutbound.java 81.81% <76.92%> (-1.52%) 28 <5> (ø)
...or/ipc/netty/channel/ChannelOperationsHandler.java 65.57% <0%> (-0.44%) 61% <0%> (ø)
...or/ipc/netty/http/client/HttpClientOperations.java 56.73% <0%> (+0.25%) 81% <0%> (+1%) ⬆️
...actor/ipc/netty/http/server/HttpServerHandler.java 79.16% <0%> (+2.08%) 41% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcde045...856848c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants