Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #411: Apply compression predicate before sendFile invocation #415

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

violetagg
Copy link
Member

Compression predicate has to be applied before sendFile invocation
because when there is a compression in place, send file with zero copy
cannot be used.

Compression predicate has to be applied before sendFile invocation
because when there is a compression in place, send file with zero copy
cannot be used.
@violetagg violetagg requested a review from smaldini August 16, 2018 08:56
@violetagg violetagg added this to the 0.7.9.RELEASE milestone Aug 16, 2018
@violetagg violetagg changed the base branch from master to 0.7.x August 16, 2018 08:57
@codecov-io
Copy link

codecov-io commented Aug 16, 2018

Codecov Report

Merging #415 into 0.7.x will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##              0.7.x     #415      +/-   ##
============================================
+ Coverage     69.08%   69.38%   +0.29%     
- Complexity     1049     1057       +8     
============================================
  Files            72       72              
  Lines          4419     4422       +3     
  Branches        639      639              
============================================
+ Hits           3053     3068      +15     
+ Misses          977      972       -5     
+ Partials        389      382       -7
Impacted Files Coverage Δ Complexity Δ
...in/java/reactor/ipc/netty/http/HttpOperations.java 68.83% <ø> (ø) 22 <0> (ø) ⬇️
...or/ipc/netty/http/server/HttpServerOperations.java 68.75% <100%> (+1.55%) 58 <3> (+5) ⬆️
.../ipc/netty/http/server/HttpServerWSOperations.java 63.15% <0%> (-3.51%) 14% <0%> (-1%)
...or/ipc/netty/channel/ChannelOperationsHandler.java 66.22% <0%> (+0.21%) 61% <0%> (+1%) ⬆️
...or/ipc/netty/http/client/HttpClientOperations.java 57.59% <0%> (+0.78%) 80% <0%> (+1%) ⬆️
.../ipc/netty/channel/PooledClientContextHandler.java 64.7% <0%> (+0.84%) 26% <0%> (ø) ⬇️
...a/reactor/ipc/netty/channel/ChannelOperations.java 83.46% <0%> (+1.57%) 48% <0%> (+1%) ⬆️
src/main/java/reactor/ipc/netty/FutureMono.java 69.16% <0%> (+1.66%) 8% <0%> (ø) ⬇️
...java/reactor/ipc/netty/channel/ContextHandler.java 75.72% <0%> (+2.91%) 27% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc9e43f...caa1adf. Read the comment docs.

@violetagg violetagg merged commit caa1adf into 0.7.x Aug 16, 2018
@violetagg violetagg deleted the issue-411 branch August 16, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants