Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #384 Consider protocol information when applying the default security configuration #394

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

violetagg
Copy link
Member

No description provided.

@violetagg violetagg requested a review from smaldini July 19, 2018 15:35
@violetagg violetagg added this to the 0.8.0.M1 milestone Jul 19, 2018
@codecov-io
Copy link

codecov-io commented Jul 19, 2018

Codecov Report

Merging #394 into master will increase coverage by 0.74%.
The diff coverage is 92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #394      +/-   ##
============================================
+ Coverage     63.32%   64.06%   +0.74%     
- Complexity     1180     1201      +21     
============================================
  Files           117      117              
  Lines          5578     5610      +32     
  Branches        728      732       +4     
============================================
+ Hits           3532     3594      +62     
+ Misses         1647     1616      -31     
- Partials        399      400       +1
Impacted Files Coverage Δ Complexity Δ
...va/reactor/netty/http/server/HttpServerSecure.java 100% <100%> (+11.11%) 2 <1> (-1) ⬇️
...java/reactor/netty/http/server/HttpServerBind.java 35.32% <100%> (+7.34%) 19 <9> (+5) ⬆️
src/main/java/reactor/netty/tcp/TcpServerBind.java 82.22% <100%> (+0.82%) 11 <4> (+2) ⬆️
src/main/java/reactor/netty/tcp/SslProvider.java 74.45% <88.88%> (+1.95%) 25 <6> (+5) ⬆️
...eactor/netty/http/server/HttpServerOperations.java 68% <0%> (+0.5%) 58% <0%> (+1%) ⬆️
...ctor/netty/resources/PooledConnectionProvider.java 78.29% <0%> (+0.85%) 11% <0%> (+1%) ⬆️
src/main/java/reactor/netty/FutureMono.java 67.5% <0%> (+2.5%) 8% <0%> (ø) ⬇️
src/main/java/reactor/netty/tcp/TcpServer.java 48.52% <0%> (+2.94%) 18% <0%> (+1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687de01...d6074d4. Read the comment docs.

@violetagg violetagg merged commit d6074d4 into master Jul 20, 2018
@violetagg violetagg deleted the issue-384 branch July 20, 2018 06:19
@violetagg violetagg mentioned this pull request Jul 26, 2018
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants