Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP/3 client initial settings #3311

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Add HTTP/3 client initial settings #3311

merged 3 commits into from
Jun 24, 2024

Conversation

violetagg
Copy link
Member

Related to #1531

@violetagg violetagg added the type/enhancement A general enhancement label Jun 24, 2024
@violetagg violetagg added this to the 1.2.0-M4 milestone Jun 24, 2024
@violetagg violetagg requested a review from a team June 24, 2024 07:03
@violetagg violetagg force-pushed the http-client-http3-settings branch from dd2013b to 4ba2a0b Compare June 24, 2024 07:05
@pderop
Copy link
Contributor

pderop commented Jun 24, 2024

In Http3ChannelInitializer, I see that the idleTimeoutattribute is not used anymore, because the quick server codec builder maxIdleTimeout is now initialized from http3Settings.idleTimeout().

So, is it necessary to keep this attribute ?

@violetagg
Copy link
Member Author

In Http3ChannelInitializer, I see that the idleTimeoutattribute is not used anymore, because the quick server codec builder maxIdleTimeout is now initialized from http3Settings.idleTimeout().

So, is it necessary to keep this attribute ?

Fixed that, please check again

@violetagg
Copy link
Member Author

@pderop Thanks for the review!

@violetagg violetagg merged commit 66b7d90 into main Jun 24, 2024
14 checks passed
@violetagg violetagg deleted the http-client-http3-settings branch June 24, 2024 12:58
violetagg added a commit that referenced this pull request Jun 24, 2024
@violetagg
Merge-ignore #3311 into 2.0.0-M4
b0f5ba9 
Netty Quic Codec and HTTP3 Codec are not migrated to Netty5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
1.2.0-M4
Development

Successfully merging this pull request may close these issues.
2 participants
@violetagg @pderop