Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #303 After aggregating the content invoke the super method. #304

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

violetagg
Copy link
Member

No description provided.

@violetagg violetagg requested a review from smaldini March 2, 2018 14:17
@violetagg violetagg added the type/bug A general bug label Mar 2, 2018
@violetagg violetagg added this to the 0.7.6.RELEASE milestone Mar 2, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@7cd547f). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #304   +/-   ##
=========================================
  Coverage          ?   68.07%           
  Complexity        ?     1018           
=========================================
  Files             ?       73           
  Lines             ?     4295           
  Branches          ?      616           
=========================================
  Hits              ?     2924           
  Misses            ?      996           
  Partials          ?      375
Impacted Files Coverage Δ Complexity Δ
...or/ipc/netty/http/client/HttpClientOperations.java 57.36% <100%> (ø) 80 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd547f...f442243. Read the comment docs.

Copy link
Contributor

@smaldini smaldini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frankly there are different improvements i hope we can make in this api in 0.8 :) good catch @violetagg

@violetagg violetagg merged commit f442243 into master Mar 2, 2018
@violetagg violetagg deleted the issue-303 branch March 8, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants