Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo #150 http codec config on 0.7 #263

Merged
merged 2 commits into from
Jan 18, 2018
Merged

Redo #150 http codec config on 0.7 #263

merged 2 commits into from
Jan 18, 2018

Conversation

simonbasle
Copy link
Contributor

This is a redo of #252 that fixes #150 in a way closer to the 0.8 version (#256), at least in the way all 5 parameters are exposed in the builder API independently.

This commits exposes options from Netty's HttpServerCodec (that is
maxInitialLineLength, maxHeaderSize and maxChunkSize) through our
HttpServerOptions. This should allow the codec to decode requests
on very long URIs.
@simonbasle simonbasle added this to the 0.7.3.RELEASE milestone Jan 18, 2018
@simonbasle simonbasle self-assigned this Jan 18, 2018
@simonbasle simonbasle requested a review from violetagg January 18, 2018 10:14
@codecov-io
Copy link

codecov-io commented Jan 18, 2018

Codecov Report

Merging #263 into master will increase coverage by 0.87%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #263      +/-   ##
============================================
+ Coverage     67.09%   67.96%   +0.87%     
- Complexity      998     1008      +10     
============================================
  Files            73       73              
  Lines          4212     4255      +43     
  Branches        598      602       +4     
============================================
+ Hits           2826     2892      +66     
+ Misses         1024     1005      -19     
+ Partials        362      358       -4
Impacted Files Coverage Δ Complexity Δ
...java/reactor/ipc/netty/http/server/HttpServer.java 94.36% <100%> (+0.42%) 15 <0> (ø) ⬇️
...actor/ipc/netty/http/server/HttpServerOptions.java 100% <100%> (ø) 14 <5> (+5) ⬆️
...or/ipc/netty/http/server/HttpServerOperations.java 70.3% <0%> (-0.61%) 45% <0%> (-1%)
...or/ipc/netty/http/client/HttpClientOperations.java 54.74% <0%> (+0.54%) 70% <0%> (ø) ⬇️
...or/ipc/netty/channel/ChannelOperationsHandler.java 64.33% <0%> (+0.69%) 57% <0%> (-1%) ⬇️
...in/java/reactor/ipc/netty/channel/FluxReceive.java 82.65% <0%> (+1.02%) 62% <0%> (ø) ⬇️
...a/reactor/ipc/netty/channel/ChannelOperations.java 80.59% <0%> (+1.49%) 48% <0%> (+1%) ⬆️
.../ipc/netty/channel/PooledClientContextHandler.java 60.97% <0%> (+3.25%) 25% <0%> (+2%) ⬆️
.../ipc/netty/http/client/HttpClientWSOperations.java 78.08% <0%> (+4.1%) 19% <0%> (+1%) ⬆️
...ctor/ipc/netty/resources/DefaultPoolResources.java 78.87% <0%> (+4.22%) 9% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1173f35...80269f4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for configuring the HttpRequestDecoder when creating an HttpServer
3 participants