Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TcpServer/TcpClient new API #214

Merged
merged 1 commit into from
Nov 9, 2017
Merged

TcpServer/TcpClient new API #214

merged 1 commit into from
Nov 9, 2017

Conversation

violetagg
Copy link
Member

No description provided.

@violetagg violetagg requested a review from smaldini November 8, 2017 15:04
@violetagg violetagg added this to the 0.8.0.RELEASE milestone Nov 8, 2017
@codecov-io
Copy link

Codecov Report

Merging #214 into 0.8.x will decrease coverage by 2.51%.
The diff coverage is 56.29%.

Impacted file tree graph

@@             Coverage Diff              @@
##              0.8.x     #214      +/-   ##
============================================
- Coverage     66.52%   64.01%   -2.52%     
- Complexity     1045     1112      +67     
============================================
  Files            81      101      +20     
  Lines          4335     4891     +556     
  Branches        607      656      +49     
============================================
+ Hits           2884     3131     +247     
- Misses         1070     1348     +278     
- Partials        381      412      +31
Impacted Files Coverage Δ Complexity Δ
...n/java/reactor/ipc/netty/tcp/TcpClientUnproxy.java 0% <0%> (ø) 0 <0> (?)
.../java/reactor/ipc/netty/tcp/TcpServerUnsecure.java 0% <0%> (ø) 0 <0> (?)
.../main/java/reactor/ipc/netty/DisposableServer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...actor/ipc/netty/options/InetSocketAddressUtil.java 85.29% <0%> (ø) 15 <0> (ø) ⬇️
.../java/reactor/ipc/netty/tcp/TcpClientUnsecure.java 0% <0%> (ø) 0 <0> (?)
...main/java/reactor/ipc/netty/tcp/ProxyProvider.java 0% <0%> (ø) 0 <0> (?)
...ain/java/reactor/ipc/netty/tcp/TcpClientProxy.java 0% <0%> (ø) 0 <0> (?)
...java/reactor/ipc/netty/channel/ContextHandler.java 68.93% <100%> (-3.62%) 26 <1> (-1)
...java/reactor/ipc/netty/tcp/TcpClientBootstrap.java 100% <100%> (ø) 2 <2> (?)
...java/reactor/ipc/netty/tcp/TcpServerBootstrap.java 100% <100%> (ø) 2 <2> (?)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bcf0b...ea15fd6. Read the comment docs.

@smaldini smaldini merged commit 4310c92 into reactor:0.8.x Nov 9, 2017
@violetagg violetagg deleted the 0.8.x-tcp branch November 9, 2017 08:14
@violetagg violetagg mentioned this pull request May 14, 2018
24 tasks
@violetagg violetagg modified the milestones: 0.8.0.RELEASE, 0.8.0.M1 Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants