Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle DatagramChannel in NettyContext.address #210

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

violetagg
Copy link
Member

No description provided.

@violetagg violetagg requested a review from smaldini November 6, 2017 20:04
@codecov-io
Copy link

Codecov Report

Merging #210 into master will decrease coverage by 0.14%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #210      +/-   ##
============================================
- Coverage      66.6%   66.45%   -0.15%     
+ Complexity      987      982       -5     
============================================
  Files            70       70              
  Lines          4144     4141       -3     
  Branches        592      592              
============================================
- Hits           2760     2752       -8     
- Misses         1017     1019       +2     
- Partials        367      370       +3
Impacted Files Coverage Δ Complexity Δ
src/main/java/reactor/ipc/netty/NettyContext.java 56.75% <0%> (-5.01%) 14 <0> (ø)
...eactor/ipc/netty/channel/ServerContextHandler.java 57.69% <100%> (+9.2%) 9 <1> (ø) ⬇️
...a/reactor/ipc/netty/channel/ChannelOperations.java 78.78% <50%> (-0.61%) 47 <0> (ø)
...tor/ipc/netty/channel/CloseableContextHandler.java 52.63% <0%> (-5.27%) 8% <0%> (-1%)
src/main/java/reactor/ipc/netty/FutureMono.java 81.63% <0%> (-4.09%) 4% <0%> (-1%)
.../ipc/netty/http/server/HttpServerWSOperations.java 60% <0%> (-1.82%) 13% <0%> (-1%)
.../ipc/netty/channel/PooledClientContextHandler.java 59.34% <0%> (-0.82%) 24% <0%> (-1%)
...or/ipc/netty/http/server/HttpServerOperations.java 66.85% <0%> (-0.58%) 46% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf09b52...7bb5cbc. Read the comment docs.

@violetagg violetagg added this to the 0.7.2.RELEASE milestone Nov 6, 2017
@smaldini smaldini merged commit f518f44 into master Nov 7, 2017
@smaldini smaldini deleted the netty-context-address branch November 7, 2017 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants