Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke pendingWriteOffer.test in event loop #207

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

violetagg
Copy link
Member

No description provided.

@violetagg violetagg added this to the 0.7.2.RELEASE milestone Nov 1, 2017
@violetagg violetagg requested a review from smaldini November 1, 2017 20:55
@codecov-io
Copy link

codecov-io commented Nov 1, 2017

Codecov Report

Merging #207 into master will decrease coverage by 0.16%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #207      +/-   ##
===========================================
- Coverage     66.77%   66.6%   -0.17%     
- Complexity      982     987       +5     
===========================================
  Files            70      70              
  Lines          4138    4144       +6     
  Branches        590     592       +2     
===========================================
- Hits           2763    2760       -3     
- Misses         1009    1017       +8     
- Partials        366     367       +1
Impacted Files Coverage Δ Complexity Δ
...or/ipc/netty/channel/ChannelOperationsHandler.java 56.37% <25%> (-0.36%) 49 <0> (+1)
.../ipc/netty/channel/PooledClientContextHandler.java 60.16% <0%> (-8.95%) 25% <0%> (-2%)
...in/java/reactor/ipc/netty/channel/FluxReceive.java 79.08% <0%> (+0.51%) 59% <0%> (+2%) ⬆️
...ctor/ipc/netty/http/server/CompressionHandler.java 82.14% <0%> (+7.14%) 20% <0%> (+2%) ⬆️
...va/reactor/ipc/netty/channel/AbortedException.java 45.45% <0%> (+9.09%) 6% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64835df...bf09b52. Read the comment docs.

@smaldini
Copy link
Contributor

smaldini commented Nov 3, 2017

Can increase the coverage by using send(flux.publishOn(Schedulers.single())

@violetagg violetagg force-pushed the pending-write-offer-test branch from fd30f28 to bf09b52 Compare November 3, 2017 07:15
@violetagg violetagg merged commit bf09b52 into master Nov 3, 2017
@violetagg violetagg deleted the pending-write-offer-test branch November 3, 2017 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants