Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClient's logging depends on ContextHandler's logger #227

Closed
unlimitedsola opened this issue Nov 23, 2017 · 3 comments
Closed

HttpClient's logging depends on ContextHandler's logger #227

unlimitedsola opened this issue Nov 23, 2017 · 3 comments
Labels
type/enhancement A general enhancement
Milestone
0.8.0.M1

Comments

@unlimitedsola
Copy link

discussed in: spring-projects/spring-boot#11119
@violetagg violetagg added this to the 0.8.0.RELEASE milestone Nov 28, 2017
@smaldini
Copy link
Contributor

smaldini commented Dec 4, 2017

Tracking in 0.8 with API refactor

@smaldini smaldini added the type/enhancement A general enhancement label Dec 4, 2017
@smaldini
Copy link
Contributor

we know have an explicit wiretap() API to enable it separately from logging level in 0.8

violetagg added a commit that referenced this issue Jan 17, 2018
@violetagg
fix #227: Introduce properties for enabling ssl debugging
98219ff 
(Tcp|Udp|Http)Client/Server#wiretap will add to the pipeline
SslLoggingHandler when reactor.netty.tcp.ssl.client.debug/
reactor.netty.tcp.ssl.server.debug system properties are enabled.
It will be placed before SslHandler.
violetagg added a commit that referenced this issue Jan 17, 2018
@violetagg
fix #227: Introduce properties for enabling ssl debugging
5fc8320 
(Tcp|Udp|Http)Client/Server#wiretap will add to the pipeline
SslLoggingHandler when reactor.netty.tcp.ssl.client.debug/
reactor.netty.tcp.ssl.server.debug system properties are enabled.
It will be placed before SslHandler.
smaldini pushed a commit that referenced this issue Jan 18, 2018
@violetagg @smaldini
fix #227: Introduce properties for enabling ssl debugging
5fbdd22 
(Tcp|Udp|Http)Client/Server#wiretap will add to the pipeline
SslLoggingHandler when reactor.netty.tcp.ssl.client.debug/
reactor.netty.tcp.ssl.server.debug system properties are enabled.
It will be placed before SslHandler.
@violetagg
Copy link
Member

Fixed by #262
a new API is introduced in 0.8
(Tcp|Udp|Http)Client/Server#wiretap

violetagg added a commit that referenced this issue Jan 19, 2018
@violetagg
fix #227: Introduce properties for enabling ssl debugging
6b2b059 
(Tcp|Udp|Http)Client/Server#wiretap will add to the pipeline
SslLoggingHandler when reactor.netty.tcp.ssl.client.debug/
reactor.netty.tcp.ssl.server.debug system properties are enabled.
It will be placed before SslHandler.
violetagg added a commit that referenced this issue Jan 22, 2018
@violetagg
fix #227: Introduce properties for enabling ssl debugging
e4fe7a5 
(Tcp|Udp|Http)Client/Server#wiretap will add to the pipeline
SslLoggingHandler when reactor.netty.tcp.ssl.client.debug/
reactor.netty.tcp.ssl.server.debug system properties are enabled.
It will be placed before SslHandler.
violetagg added a commit that referenced this issue Jan 24, 2018
@violetagg
fix #227: Introduce properties for enabling ssl debugging
6434281 
(Tcp|Udp|Http)Client/Server#wiretap will add to the pipeline
SslLoggingHandler when reactor.netty.tcp.ssl.client.debug/
reactor.netty.tcp.ssl.server.debug system properties are enabled.
It will be placed before SslHandler.
@violetagg violetagg mentioned this issue May 14, 2018
Closed
24 tasks
violetagg added a commit that referenced this issue May 16, 2018
@violetagg
fix #227: Introduce properties for enabling ssl debugging
ed66a45 
(Tcp|Udp|Http)Client/Server#wiretap will add to the pipeline
SslLoggingHandler when reactor.netty.tcp.ssl.client.debug/
reactor.netty.tcp.ssl.server.debug system properties are enabled.
It will be placed before SslHandler.
violetagg added a commit that referenced this issue May 28, 2018
@violetagg
fix #227: Introduce properties for enabling ssl debugging
07e42d8 
(Tcp|Udp|Http)Client/Server#wiretap will add to the pipeline
SslLoggingHandler when reactor.netty.tcp.ssl.client.debug/
reactor.netty.tcp.ssl.server.debug system properties are enabled.
It will be placed before SslHandler.
@violetagg violetagg modified the milestones: 0.8.0.RELEASE, 0.8.0.M1 Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
0.8.0.M1
Development

No branches or pull requests
3 participants
@smaldini @violetagg @unlimitedsola