Skip to content

Commit

Permalink
fix #339 Remove the additional logging, the error is propagated
Browse files Browse the repository at this point in the history
  • Loading branch information
violetagg committed Apr 26, 2018
1 parent e6634c2 commit 74912c5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 25 deletions.
24 changes: 0 additions & 24 deletions src/main/java/reactor/ipc/netty/channel/ChannelOperations.java
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,6 @@ protected void onOutboundComplete() {
* @param err the {@link Throwable} cause
*/
protected void onOutboundError(Throwable err) {
discreteRemoteClose(err);
markPersistent(false);
onHandlerTerminate();
}
Expand All @@ -386,28 +385,6 @@ protected final void applyHandler() {
}
}

/**
* Try filtering out remote close unless traced, return true if filtered
*
* @param err the error to check
*
* @return true if filtered
*/
protected final boolean discreteRemoteClose(Throwable err) {
if (AbortedException.isConnectionReset(err)) {
if (log.isDebugEnabled()) {
log.debug("{} [{}] Connection closed remotely", channel.toString(),
formatName(),
err);
}
return true;
}

log.error("[" + formatName() + "] Error processing connection. Requesting close the channel",
err);
return false;
}

/**
* Final release/close (last packet)
*/
Expand Down Expand Up @@ -448,7 +425,6 @@ protected final void discard(){
* @param err the {@link Throwable} cause
*/
protected final void onInboundError(Throwable err) {
discreteRemoteClose(err);
inbound.onInboundError(err);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,6 @@ protected void onOutboundError(Throwable err) {
return;
}

discreteRemoteClose(err);
if (markSentHeaders()) {
log.error("Error starting response. Replying error status", err);

Expand Down

0 comments on commit 74912c5

Please sign in to comment.