Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(cn): translate reference/react/useInsertionEffect into Chinese #1166
docs(cn): translate reference/react/useInsertionEffect into Chinese #1166
Changes from 9 commits
e193b95
260b1ce
b27848a
8e5641c
771dfdb
8661373
847c217
f49d8d0
6140c63
30b76c3
df0a49a
15b24ef
9267df5
ec6894c
4ef9216
a588cef
f35b08e
a85bc25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“附加”这个表达感觉有点点怪,有没有其他更合适的表达方式?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
当初翻译的时候,考虑如下:
ref
如果用于计算值的时候,使用 赋值 比较合适;ref
如果用于DOM
的时候,使用 赋值 感觉差点意思,故使用了attach
的直译 附加;暂未想到对
attach
更好的表达方式,但是 赋值 并无不妥之处。如同意,我会将其改为 赋值。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以考虑加个因果关系?类似于:因为 DOM 还没有更新,所以 ref 还没有被赋值。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个因果关系是确认的吗?