Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cn): translate learn/choosing-the-state-structure into Chinese #1094

Merged
merged 53 commits into from
May 12, 2023

Conversation

Davont
Copy link
Contributor

@Davont Davont commented Mar 23, 2023

翻译 choosing-the-state-structure
之前的翻译 PR #638 已经过时,现已更新

感谢检视! @QC-L @awxiaoxian2020

@github-actions
Copy link

github-actions bot commented Mar 23, 2023

Size changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.63 KB (🟡 +4 B) 170.26 KB
/500 76.63 KB (🟡 +4 B) 170.26 KB
/[[...markdownPath]] 78.19 KB (🟡 +4 B) 171.82 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@awxiaoxian2020 awxiaoxian2020 requested a review from Yucohny March 23, 2023 14:30
src/content/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
src/content/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
src/content/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
src/content/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
src/sidebarLearn.json Outdated Show resolved Hide resolved
Davont and others added 4 commits March 24, 2023 12:54
Co-authored-by: Xavi Lee <awxiaoxian2020@163.com>
Co-authored-by: Xavi Lee <awxiaoxian2020@163.com>
Co-authored-by: Xavi Lee <awxiaoxian2020@163.com>
Co-authored-by: Xavi Lee <awxiaoxian2020@163.com>
Co-authored-by: Xavi Lee <awxiaoxian2020@163.com>
@Davont
Copy link
Contributor Author

Davont commented Apr 22, 2023

已经更新解决,辛苦检视~

@Davont
Copy link
Contributor Author

Davont commented Apr 27, 2023

@awxiaoxian2020 打扰下,我看 pr 的最下文显示 :
Merging can be performed automatically once the requested changes are addressed.

但是我已经更改好了,没看到哪里没有修改的,请问这个怎么解决呢?

@awxiaoxian2020
Copy link
Collaborator

@awxiaoxian2020 打扰下,我看 pr 的最下文显示 : Merging can be performed automatically once the requested changes are addressed.

但是我已经更改好了,没看到哪里没有修改的,请问这个怎么解决呢?

这只是因为我使用了 request changes 且我并没有更新我的 review 状态,所以只要我没有 approve,那么就会一直是这个状态,并不会因为你的提交而改变~不用管它

@awxiaoxian2020 awxiaoxian2020 merged commit 189f439 into reactjs:main May 12, 2023
@awxiaoxian2020 awxiaoxian2020 self-assigned this May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending Review 已翻译,待校对阶段
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants