Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typechecking with Proptypes translated #98

Merged
merged 8 commits into from
Apr 8, 2019
Merged

Typechecking with Proptypes translated #98

merged 8 commits into from
Apr 8, 2019

Conversation

vburlai
Copy link
Contributor

@vburlai vburlai commented Apr 6, 2019

Typechecking with Proptypes translated

@vburlai vburlai mentioned this pull request Apr 6, 2019
Closed
92 tasks
vburlai
vburlai commented Apr 6, 2019
View reviewed changes
content/docs/typechecking-with-proptypes.md Outdated
optionalArray: PropTypes.array,
optionalBool: PropTypes.bool,
optionalFunc: PropTypes.func,
optionalFunc: PropTypes.func, // наприклад, приймає функцію або відсутнє значення
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I somehow give hints about meanings of variable names?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klymenkoo @mihilbabin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optionalFunc => опціональна функція, про що тут гадати?:)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@netlify
Copy link

netlify bot commented Apr 6, 2019 •
edited
Loading

Deploy preview for uk-reactjs ready!

Built with commit 34506fc

https://deploy-preview-98--uk-reactjs.netlify.com

@oleksii-polovyi oleksii-polovyi added the Просунуті Теми Advanced Guides part of documentation label Apr 7, 2019
oleksii-polovyi
oleksii-polovyi requested changes Apr 7, 2019
View reviewed changes
Copy link
Member

@oleksii-polovyi oleksii-polovyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start 😃
Please follow up with the suggestions below.

content/docs/typechecking-with-proptypes.md Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Show resolved Hide resolved
mihilbabin
mihilbabin suggested changes Apr 8, 2019
View reviewed changes
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
vldmrkl
vldmrkl requested changes Apr 8, 2019
View reviewed changes
Copy link
Member

@vldmrkl vldmrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую за переклад 🙌
Треба трошки виправити, і можна буде заливати в мастер 😀

content/docs/typechecking-with-proptypes.md Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
@vburlai
Copy link
Contributor Author

vburlai commented Apr 8, 2019

Hi @klymenkoo and @ApolllonDev,

Thank you for reviewing.
I've applied the changes.

@vldmrkl
Copy link
Member

vldmrkl commented Apr 8, 2019

@vburlai Awesome 🔥🔥🔥
Thank you so much 🙌

@vldmrkl vldmrkl merged commit 52f181a into reactjs:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksii-polovyi oleksii-polovyi oleksii-polovyi requested changes

@vldmrkl vldmrkl vldmrkl approved these changes

@mihilbabin mihilbabin mihilbabin approved these changes

Assignees

@vburlai vburlai

Labels
Потрібні зміни Просунуті Теми Advanced Guides part of documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vburlai @vldmrkl @mihilbabin @oleksii-polovyi