Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated getting-started page and nav #60

Closed
wants to merge 3 commits into from
Closed

Translated getting-started page and nav #60

wants to merge 3 commits into from

Conversation

PetroOstapuk
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Mar 8, 2019 •
edited
Loading

Deploy preview for uk-reactjs ready!

Built with commit 043303c

https://deploy-preview-60--uk-reactjs.netlify.com

mihilbabin
mihilbabin suggested changes Mar 8, 2019
View reviewed changes
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
@PetroOstapuk
Update getting-started.md
7036daa 
Виправлення помилок
@PetroOstapuk
Update nav.yml
043303c 
Виправлення помилок
@Kurzdor
Copy link
Contributor

Kurzdor commented Mar 9, 2019 •
edited
Loading

eem, this section was already taken by me.
Awesome.
#58

@PetroOstapuk
Copy link
Contributor Author

Sorry, it's my mistake. I didn't look to other pullrequests, and took first not translate

@vldmrkl
Copy link
Member

vldmrkl commented Mar 10, 2019

@Kurzdor, @PetRichOst, guys thank you both for your hard work and contributions. I feel bad for this misunderstanding. I really appreciate your time and effort, and I don't want to leave any of your work unnoticed. How about this was to resolve this issue:

It seems like @Kurzdor has translated the first half of the document only so far. We would review and work on it, and then merge it + @Kurzdor has some more PRs opened that he needs to finish.

@PetRichOst we would work on the second half of the document, so we can have both of your contributions.

How does that sound?

Again, thank you for your contributions guys. I would be happy to see you contributing more in the future.

@tesseralis tesseralis mentioned this pull request Mar 10, 2019
Closed
92 tasks
oleksii-polovyi
oleksii-polovyi approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@oleksii-polovyi oleksii-polovyi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleksii-polovyi oleksii-polovyi added Дублікат This issue or pull request already exists Встановлення Installation part of documentation labels Mar 12, 2019
@PetroOstapuk
Copy link
Contributor Author

Thank you! I full agree with this decision.

vldmrkl
vldmrkl requested changes Mar 20, 2019
View reviewed changes
Copy link
Member

@vldmrkl vldmrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую за переклад. Перевірив другу частину вашого перекладу, треба зробити кілька виравлень 🙌

content/docs/getting-started.md Show resolved Hide resolved
content/docs/getting-started.md Show resolved Hide resolved
content/docs/getting-started.md Show resolved Hide resolved
content/docs/getting-started.md Show resolved Hide resolved
content/docs/getting-started.md Show resolved Hide resolved
content/docs/getting-started.md Show resolved Hide resolved
@vldmrkl vldmrkl removed Встановлення Installation part of documentation Дублікат This issue or pull request already exists labels Mar 20, 2019
@vldmrkl vldmrkl mentioned this pull request Mar 29, 2019
Closed
@vldmrkl vldmrkl closed this Mar 29, 2019
@vldmrkl vldmrkl mentioned this pull request Mar 30, 2019
Merged
vldmrkl added a commit that referenced this pull request Mar 30, 2019
@vldmrkl
Merge pull request #93 from klymenkoo/getting-started
590addf 
Re-creating $58 & #60 (Getting Started)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihilbabin mihilbabin mihilbabin requested changes

@vldmrkl vldmrkl vldmrkl requested changes

@oleksii-polovyi oleksii-polovyi oleksii-polovyi approved these changes

Assignees

@PetroOstapuk PetroOstapuk

Labels
priority: high Потрібні зміни
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PetroOstapuk @Kurzdor @vldmrkl @mihilbabin @oleksii-polovyi