Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of the "Render and Commit" #534

Merged
merged 11 commits into from
Dec 29, 2024
Merged

Translation of the "Render and Commit" #534

merged 11 commits into from
Dec 29, 2024

Conversation

kpripper
Copy link
Contributor

This pull request includes a translation of the "Render and Commit" feature.

@vercel Vercel
Copy link

vercel bot commented Apr 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
uk-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Dec 29, 2024 9:38pm

alinkedd
alinkedd requested changes Apr 21, 2024
View reviewed changes
Copy link
Collaborator

@alinkedd alinkedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую за PR

Спробуй виправити помилки і перечитати правила пунктуація, а також Translation файл. Більшість коментарів щодо вживання і правил відносяться не тільки до цього місця, а до всієї статті.

Рекомендую після змін (через один-два дні) прочитати тільки українську версію статті на локалхості, ніби читаєш чужу документацію, щоб відчути, чи все зрозуміло, чи легко читається, чи не схоже на машинний переклад.

.vscode/settings.json Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
@alinkedd alinkedd mentioned this pull request Apr 22, 2024
Open
undead404
undead404 reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@undead404 undead404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пробігав повз, вирішив почитати. Кілька загальних зауважень для автора:

  • Перекладайте менш буквально, але краще відтворюючи зміст. Спробуйте зачитати вголос власний переклад – і самі зрозумієте, як покращити речення.
  • Розберіться, де у вас рендер, а де рендеринг. Ми на WebDoky перекладаємо це як "візуалізацію", але для документації React такий переклад, очевидно, не підходит

Не сприймайте за насильницьке вторгнення! Залюбки відповім на коментарі

src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
@alinkedd alinkedd mentioned this pull request Dec 29, 2024
Draft
alinkedd and others added 2 commits December 29, 2024 19:10
@alinkedd @undead404
Apply suggestions from code review
a50273b 
Co-authored-by: Vitalii Perehonchuk <brute18@gmail.com>
@alinkedd @undead404
Apply suggestions from code review
7172670 
Co-authored-by: Vitalii Perehonchuk <brute18@gmail.com>
alinkedd
alinkedd requested changes Dec 29, 2024
View reviewed changes
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 29, 2024 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@alinkedd alinkedd merged commit 4300ef0 into reactjs:main Dec 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@undead404 undead404 undead404 left review comments

@alinkedd alinkedd alinkedd approved these changes

@valdemarua valdemarua valdemarua left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpripper @valdemarua @alinkedd @undead404