Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create TRANSLATION.md #5

Merged
merged 8 commits into from
Feb 12, 2019
Merged

Create TRANSLATION.md #5

merged 8 commits into from
Feb 12, 2019

Conversation

oleksii-polovyi
Copy link
Member

@klymenkoo @ithompson4
This file contains translations of terms.
Please review.

@oleksii-polovyi oleksii-polovyi self-assigned this Feb 12, 2019
@oleksii-polovyi oleksii-polovyi added the Поліпшення New feature or request label Feb 12, 2019
@oleksii-polovyi oleksii-polovyi mentioned this pull request Feb 12, 2019
Closed
92 tasks
vldmrkl
vldmrkl requested changes Feb 12, 2019
View reviewed changes
Copy link
Member

@vldmrkl vldmrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @ApolllonDev!
Just a couple of small changes, and it's good to go.

TRANSLATION.md Outdated Show resolved Hide resolved
TRANSLATION.md Outdated Show resolved Hide resolved
TRANSLATION.md Outdated Show resolved Hide resolved
TRANSLATION.md Outdated Show resolved Hide resolved
TRANSLATION.md Outdated Show resolved Hide resolved
vldmrkl
vldmrkl requested changes Feb 12, 2019
View reviewed changes
Copy link
Member

@vldmrkl vldmrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small change, and it'll be shipped 🚢

TRANSLATION.md Outdated Show resolved Hide resolved
@mihilbabin mihilbabin mentioned this pull request Feb 12, 2019
Merged
westanvv
westanvv reviewed Feb 12, 2019
View reviewed changes
TRANSLATION.md Outdated Show resolved Hide resolved
@westanvv
Copy link
Contributor

Offer to add: valid - валідний

@oleksii-polovyi
Copy link
Member Author

oleksii-polovyi commented Feb 12, 2019 •
edited
Loading

@klymenkoo
Should I add rendered markup translation as інтерфейс користувача?

@vldmrkl
Copy link
Member

vldmrkl commented Feb 12, 2019 •
edited by oleksii-polovyi
Loading

@klymenkoo
Should I add rendered markup translation as інтерфейс користувача?

I would translate Rendered markup as Відрендерена розмітка.
UI is інтерфейс користувача.

Those are different terms.

@vldmrkl
Copy link
Member

vldmrkl commented Feb 12, 2019

@ApolllonDev looks good! thank you for your contribution 👏

@vldmrkl vldmrkl merged commit 2697e27 into reactjs:master Feb 12, 2019
@oleksii-polovyi oleksii-polovyi deleted the uk-translation-md branch February 12, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westanvv westanvv westanvv left review comments

@vldmrkl vldmrkl vldmrkl approved these changes

@ithompson4 ithompson4 Awaiting requested review from ithompson4

Assignees

@oleksii-polovyi oleksii-polovyi

Labels
Поліпшення New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksii-polovyi @westanvv @vldmrkl