Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added translation for "React without ES6" section #48

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Added translation for "React without ES6" section #48

merged 3 commits into from
Mar 6, 2019

Conversation

Kurzdor
Copy link
Contributor

@Kurzdor Kurzdor commented Feb 28, 2019

No description provided.

@netlify
Copy link

netlify bot commented Feb 28, 2019 •
edited
Loading

Deploy preview for uk-reactjs ready!

Built with commit 0c6db65

https://deploy-preview-48--uk-reactjs.netlify.com

liashchynskyi
liashchynskyi suggested changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@liashchynskyi liashchynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

поки переглянув тільки половину)

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@vldmrkl
Copy link
Member

vldmrkl commented Feb 28, 2019

@Kurzdor Thanks for the contribution 🙌Your effort is very much appreciated 👍
Can I ask you to work on one section per time, please? It seems difficult to work on several of them in parallel, so it'd be more efficient to focus on one and switch to another one once the first one is finished.
Could you also please polish your PRs because there are currently two PRs for "React without JSX" opened.

@liashchynskyi
Copy link
Contributor

@klymenko another one is about React without ES6. @Kurzdor just forgot to change the title)

@klymenko
Copy link

@klymenko another one is about React without ES6. @Kurzdor just forgot to change the title)

It's a wrong @klymenko :)

oleksii-polovyi
oleksii-polovyi requested changes Feb 28, 2019
View reviewed changes
Copy link
Member

@oleksii-polovyi oleksii-polovyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggested changes.

content/docs/react-without-es6.md Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@Kurzdor Kurzdor changed the title Added translation for "React without JSX" section Added translation for "React without ES6" section Feb 28, 2019
@Kurzdor
Copy link
Contributor Author

Kurzdor commented Feb 28, 2019 •
edited
Loading

@klymenkoo @liashchynskyi Я випадково переплутав назву комміту і PR з React without JSX :)

@vldmrkl vldmrkl added the Просунуті Теми Advanced Guides part of documentation label Mar 2, 2019
vldmrkl
vldmrkl requested changes Mar 3, 2019
View reviewed changes
Copy link
Member

@vldmrkl vldmrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Гарний початок 👍Треба зробити декілька виправлень.

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@vldmrkl vldmrkl merged commit 14cc253 into reactjs:master Mar 6, 2019
@tesseralis tesseralis mentioned this pull request Mar 6, 2019
Closed
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihilbabin mihilbabin mihilbabin left review comments

@liashchynskyi liashchynskyi liashchynskyi requested changes

@vldmrkl vldmrkl vldmrkl approved these changes

@oleksii-polovyi oleksii-polovyi oleksii-polovyi approved these changes

Assignees

@Kurzdor Kurzdor

Labels
Просунуті Теми Advanced Guides part of documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kurzdor @vldmrkl @liashchynskyi @klymenko @mihilbabin @oleksii-polovyi